Skip to content

feat: remove unused crosscompile target and gox dependency#45555

Merged
kruskall merged 6 commits intoelastic:mainfrom
kruskall:feat/drop-gox
Nov 4, 2025
Merged

feat: remove unused crosscompile target and gox dependency#45555
kruskall merged 6 commits intoelastic:mainfrom
kruskall:feat/drop-gox

Conversation

@kruskall
Copy link
Member

@kruskall kruskall commented Jul 25, 2025

Proposed commit message

gox has been archived and is no longer maintained

the crosscompile target is not used anymore

it was initially added in the travis era, later ported over in buildkite and removed in #43406

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@kruskall
feat: remove unused crosscompile target and gox dependency
e621da8 
gox has been archived and is no longer maintained

the crosscompile target is not used anymore

remove it
@kruskall kruskall requested review from a team as code owners July 25, 2025 14:26
@kruskall kruskall requested review from leehinman and mauri870 July 25, 2025 14:26
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 25, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 25, 2025

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@mergify
Copy link
Contributor

mergify bot commented Jul 25, 2025

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @kruskall? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@pierrehilbert pierrehilbert added Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team Team:Security-Linux Platform Linux Platform Team in Security Solution Team:Security-Windows Platform Windows Platform Team in Security Solution Team:Security-Deployment and Devices Deployment and Devices Team in Security Solution labels Jul 25, 2025
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 25, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 25, 2025

Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform)

@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 25, 2025

Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform)

@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 25, 2025

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 25, 2025

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

mauri870
mauri870 approved these changes Jul 28, 2025
View reviewed changes
Copy link
Member

@mauri870 mauri870 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! I have a PR removing some of the mitchellh dependencies and Gox was the remaining one, since it was a tool I did not bother removing it. Good to know that it can also be removed.

v1v
v1v reviewed Jul 28, 2025
View reviewed changes
Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not much familiar with the usage of GOX_FLAGS, but I wonder whether the packaging DRA or so needs to be executed to validate whether these changes have any impact?

@mauri870 mauri870 mentioned this pull request Jul 30, 2025
Merged
6 tasks
This was referenced Aug 4, 2025
Merged
Merged
Merged
@kruskall kruskall requested a review from a team as a code owner August 5, 2025 03:24
@mergify
Copy link
Contributor

mergify bot commented Aug 11, 2025

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b feat/drop-gox upstream/feat/drop-gox
git merge upstream/main
git push upstream feat/drop-gox

@kruskall
Copy link
Member Author

kruskall commented Aug 20, 2025

@elastic/beats-tech-leads @elastic/observablt-ci @elastic/observablt-ci-contractors @elastic/sec-linux-platform @elastic/sec-windows-platform friendly ping for review

@kruskall
Copy link
Member Author

kruskall commented Sep 9, 2025

@elastic/sec-windows-platform @elastic/sec-linux-platform friendly ping for review

v1v
v1v approved these changes Sep 10, 2025
View reviewed changes
Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved - I only reviewed the BK pieces

@kruskall
Copy link
Member Author

kruskall commented Sep 23, 2025

@elastic/sec-windows-platform @elastic/sec-linux-platform friendly ping for review

1 similar comment
@kruskall
Copy link
Member Author

kruskall commented Oct 8, 2025

@elastic/sec-windows-platform @elastic/sec-linux-platform friendly ping for review

@pierrehilbert
Copy link
Contributor

pierrehilbert commented Oct 9, 2025

@nfritts could you please take a look here?

@kruskall kruskall merged commit 2cc9df7 into elastic:main Nov 4, 2025
255 checks passed
@kruskall kruskall deleted the feat/drop-gox branch November 4, 2025 16:18
andrzej-stencel pushed a commit to andrzej-stencel/beats that referenced this pull request Dec 1, 2025
@kruskall @andrzej-stencel
feat: remove unused crosscompile target and gox dependency (elastic#4…
a4b19c9 
…5555)

* feat: remove unused crosscompile target and gox dependency

gox has been archived and is no longer maintained

the crosscompile target is not used anymore

remove it

* lint: regenerate notice file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@v1v v1v v1v approved these changes

@cmacknz cmacknz cmacknz approved these changes

@mauri870 mauri870 mauri870 approved these changes

@nfritts nfritts nfritts approved these changes

@leehinman leehinman leehinman approved these changes

@taylor-swanson taylor-swanson taylor-swanson approved these changes

+1 more reviewer

@oakrizan oakrizan oakrizan left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@kruskall kruskall

Labels

Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team Team:Security-Deployment and Devices Deployment and Devices Team in Security Solution Team:Security-Linux Platform Linux Platform Team in Security Solution Team:Security-Windows Platform Windows Platform Team in Security Solution

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@kruskall @elasticmachine @pierrehilbert @v1v @cmacknz @mauri870 @oakrizan @nfritts @leehinman @taylor-swanson